feat: download WASI SDK from cargo build script #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sl1mb0
force-pushed
the
tm/cargo-build-wasi-sdk
branch
from
94f7706 to
a8564a0
Compare
Copilot finished reviewing on behalf of
Sl1mb0
November 19, 2025 13:15
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR automates the WASI SDK download process by moving it from a Just/bash script into the Cargo build script. This improves the developer experience by making the build more self-contained and eliminating the need to manually run separate download commands.
Key Changes
- Implemented automatic WASI SDK sysroot download and verification in
build.rs - Added necessary dependencies for download and extraction (ureq, flate2, sha2)
- Converted the Justfile
download-wasi-sdktarget to a no-op with informational message
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| guests/python/build.rs | Added download_wasi_sdk() function with download, SHA256 verification, and extraction logic; added imports for new dependencies |
| guests/python/Cargo.toml | Added build dependencies: flate2, sha2, and ureq for HTTP download and archive handling |
| guests/python/Justfile | Replaced bash script for WASI SDK download with informational message noting automation in build.rs |
| Cargo.lock | Dependency graph updates for new build dependencies and their transitive dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
crepererum
reviewed
Nov 19, 2025
Sl1mb0
force-pushed
the
tm/cargo-build-wasi-sdk
branch
2 times, most recently
from
2021889 to
d1e1233
Compare
crepererum
reviewed
Nov 20, 2025
crepererum
reviewed
Nov 20, 2025
Sl1mb0
force-pushed
the
tm/cargo-build-wasi-sdk
branch
2 times, most recently
from
5757d69 to
1bc6ae3
Compare
crepererum
reviewed
Nov 21, 2025
Sl1mb0
force-pushed
the
tm/cargo-build-wasi-sdk
branch
from
1bc6ae3 to
44e381e
Compare
Sl1mb0
force-pushed
the
tm/cargo-build-wasi-sdk
branch
from
e104cc2 to
8ef1058
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20
Describe your proposed changes here.