feat: utxo locking #112
Merged
feat: utxo locking #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhyslbw
reviewed
Oct 12, 2021
rhyslbw
reviewed
Oct 12, 2021
Member
rhyslbw
left a comment
rhyslbw
left a comment
There was a problem hiding this comment.
This was drafted in the previous review, but it must have been deleted when I thought I was de-duping responses.
mkazlauskas
force-pushed
the
feat/utxo-lock
branch
3 times, most recently
from
0b6f39d to
4fd158b
Compare
rhyslbw
requested changes
Oct 13, 2021
Member
There was a problem hiding this comment.
Great work here @mkazlauskas . My review is still in progress, but submitting early for advanced notice. What does the withdrawal example look like positioned as an integration test? The need for an example is really just pointing out a gap in our tests, which gains us the assurance we cannot otherwise have with pure examples.
mkazlauskas
force-pushed
the
feat/utxo-lock
branch
from
e42d9b0 to
3312fd5
Compare
rhyslbw
requested changes
Oct 13, 2021
rhyslbw
requested changes
Oct 13, 2021
Member
rhyslbw
left a comment
rhyslbw
left a comment
There was a problem hiding this comment.
Looks good! Please squash into minimal commits, then we're ready to merge.
feat(wallet): implement InMemoryTransactionTracker
…to it refactor: change Provider.submitTx return type to Promise<void>, use ProviderError
…withdrawal.ts, enable coverage
…th availableUtxo set
refactor(wallet): change event-naming, rename trackTransaction->track, a few small improvements
mkazlauskas
force-pushed
the
feat/utxo-lock
branch
from
d3c0e5b to
a5bc91f
Compare
rhyslbw
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Need to provide functionality that wallets need to prevent double-spend attempts.
Proposed Solution
availableUtxosfield toUtxoRepositoryand implement it forInMemoryUtxoRepositoryInMemoryTransactionTrackerImportant Changes Introduced
flushPromisesutility function toutil-devpackage,cslToOgmios.txIntocorepackagetransactionUntrackedevent toInMemoryUtxoRepository. To recover user should attempt to call TransactionTracker.trackTransaction manually.MockProviderto usejest.fnforutxoDelegationAndRewardsand a few other provider functions.ProviderErrorand implement the conversion forblockfrostProvider.@typescript-eslint/no-floating-promisesand disable@typescript-eslint/no-var-requires(covered by unicorn/prefer-module)