operator: move deviceplugin/v1 CRDs to cluster scope

[mythi]

Closes: #556

[mythi]

I had to split these into two because one was still too "complex"

[rojkov]

Perhaps moving *.SetupWebhookWithManager() into *.SetupReconsiler() could also work. Then we could introduce a mapping of operator names to *.SetupReconsiler functions and call the functions inside the loop. This way the code would be much shorter:

for _, device := range []string{"dsa", "fpga", "gpu", "qat", "sgx"} {
        if err := setupReconcilerAndWebhookFuncs[device](mgr, ns, device); err != nil {
                setupLog.Error(...)
                os.Exit(1)
        }
}

[mythi]

@rojkov I submitted v2.

[rojkov]

Looks good to me. Please merge if the nitpicking comment doesn't look legit. I'm ok with the code as it is now.

[rojkov]

nit: when choosing between increased cyclomatics and complex logical expressions I'd take the former. I guess it would be more readable with an additional if for withWebhook and without negation:

if err := controllers.SetupWithManager(mgr, c, devicepluginv1.GroupVersion.String(), "GpuDevicePlugin", ownerKey); err != nil {
        return err
}

if withWebhook {
        return (&devicepluginv1.GpuDevicePlugin{}).SetupWebhookWithManager(mgr)
}

return nil

[mythi]

good comment, changed, v3 pushed

[rojkov]

Thanks!