Skip to content

Conversation

lukaszstolarczuk
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk commented Aug 18, 2025

Signed-off-by: Łukasz Stolarczuk <[email protected]>
@sarnex
Copy link
Contributor

sarnex commented Aug 25, 2025

sorry was on vacation. LGTM, hopefully CI failures are not related

@lukaszstolarczuk
Copy link
Contributor Author

No worries, there's no rush with this PR.

  • 2 fails looks like a random reduction tests failures
  • gen 12 looks weird - cannot download or extract SYCL toolchain; it doesn't look like it's UMF's fault.

@sarnex
Copy link
Contributor

sarnex commented Aug 25, 2025

I'll just restart CI and see what happens

@sarnex
Copy link
Contributor

sarnex commented Aug 25, 2025

Better this time, one fail that's not related

@sarnex sarnex merged commit 7bf4951 into intel:sycl Aug 25, 2025
103 of 117 checks passed
sarnex added a commit that referenced this pull request Aug 25, 2025
sarnex added a commit that referenced this pull request Aug 25, 2025
@sarnex
Copy link
Contributor

sarnex commented Aug 25, 2025

@lukaszstolarczuk I just reverted this, @aelovikov-intel found this is causing build failures if autoconf is not installed, can you take a look?

[1/553] Generating ../hwloc_targ-src/configure
FAILED: _deps/hwloc_targ-src/configure <...>/sycl/build/_deps/hwloc_targ-src/configure
cd <...>/sycl/build/_deps/hwloc_targ-src && ./autogen.sh
./autogen.sh: line 13: autoreconf: command not found
ninja: build stopped: cannot make progress due to previous errors.

github-actions bot pushed a commit to oneapi-src/unified-runtime that referenced this pull request Aug 26, 2025
@lukaszstolarczuk lukaszstolarczuk deleted the bump-umf-v1.1.0-dev2 branch August 26, 2025 12:58
@lukaszstolarczuk
Copy link
Contributor Author

@sarnex , @aelovikov-intel , well I guess it's expected. I believe it was established some time ago, that we'll remove "UMF_HWLOC_DISABLE" flag, hence will require hwloc installed in the system. If hwloc is not available we fetch it, configure and build (hence autoreconf is required).

This was done in: oneapi-src/unified-memory-framework#1228

As a mitigation I can fail early - hope this is ok for you...?
oneapi-src/unified-memory-framework#1505

@sarnex
Copy link
Contributor

sarnex commented Aug 26, 2025

If autoconf is not installed and hwloc is not preinstalled, is there any supported way to successfully build UMF? Are there some flags we can pass to UMF to make it work (besides UMF_HWLOC_DISABLE i guess since that's being removed)

If so, on the SYCL side where we are calculating the args to CMake to build UMF, we could detect autoconf is not installed and pass whatever flags are required.

If not, yeah I guess the best thing to do is have a clear error on the UMF side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants