-
Notifications
You must be signed in to change notification settings - Fork 792
[UR] Bump UMF to v1.1.0-dev2 #19818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UR] Bump UMF to v1.1.0-dev2 #19818
Conversation
Signed-off-by: Łukasz Stolarczuk <[email protected]>
sorry was on vacation. LGTM, hopefully CI failures are not related |
No worries, there's no rush with this PR.
|
I'll just restart CI and see what happens |
Better this time, one fail that's not related |
@lukaszstolarczuk I just reverted this, @aelovikov-intel found this is causing build failures if
|
@sarnex , @aelovikov-intel , well I guess it's expected. I believe it was established some time ago, that we'll remove "UMF_HWLOC_DISABLE" flag, hence will require hwloc installed in the system. If hwloc is not available we fetch it, configure and build (hence autoreconf is required). This was done in: oneapi-src/unified-memory-framework#1228 As a mitigation I can fail early - hope this is ok for you...? |
If autoconf is not installed and hwloc is not preinstalled, is there any supported way to successfully build UMF? Are there some flags we can pass to UMF to make it work (besides If so, on the SYCL side where we are calculating the args to CMake to build UMF, we could detect autoconf is not installed and pass whatever flags are required. If not, yeah I guess the best thing to do is have a clear error on the UMF side. |
It contains at least:
They both are required for #19635