[Benchmarks] Fix SubmitGraph CPU count scenarios grouping #20239
+48
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatKamin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PatKamin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PatKamin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PatKamin
force-pushed
the
fix-submitgraph-charts
branch
from
3b64724 to
f49e0dc
Compare
PatKamin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
lukaszstolarczuk
approved these changes
Sep 30, 2025
PatKamin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PatKamin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PatKamin
force-pushed
the
fix-submitgraph-charts
branch
from
f49e0dc to
cc9c41e
Compare
Fixes SubmitGraph CPU count scenarios being drawed in the same charts as SubmitGraph time measurement scenarios making them hard to read.
Simplify SubmitGraph and SubmitKernel benchmarks metadata creation.
Imports sorted with isort
There was a problem hiding this comment.
Pull Request Overview
Fixes SubmitGraph CPU count scenarios being incorrectly grouped with time measurement scenarios, improving chart readability. Also includes refactoring of the compute.py module structure.
- Separated CPU count scenarios into their own groups to prevent mixing with time measurements
- Refactored benchmark metadata creation to use
copy.deepcopy()for cleaner code - Reorganized imports for better structure
Co-authored-by: Copilot <[email protected]>
lslusarczyk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
lslusarczyk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
lslusarczyk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SubmitGraph CPU count scenarios being drawn in the same charts as
SubmitGraph time measurement scenarios making them hard to read.
Also, refactor a bit the
compute.pymodule.