[SYCL] missing SYCL_EXPORT leading to downstream troubles #7318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…original problem is that the custom specialization of get_info<parent_device> is merely missing an export declaration. If I'm right, or just dumb lucky, then this will fix all downstream failures, including post-commit. And if not, well, the symbol update is correct regardless Signed-off-by: Chris Perkins <[email protected]>
Contributor
Author
|
Here is a post-commit check run against this: https://github.com/intel/llvm/actions/runs/3421705414 |
aelovikov-intel
approved these changes
Nov 8, 2022
Contributor
|
post-commit passes, fails look flaky. |
Contributor
|
Looks like barrier_order issue was first time noticed at intel/llvm-test-suite#1122 |
Contributor
|
Opened #8798 for timeout issue with more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my earlier post-commit fix caused an ABI symbols problem downstream. But the original problem is that the custom specialization of
get_info<parent_device>is merely missing an export declaration. If I'm right, or just dumb lucky, then this will fix all downstream failures, including post-commit. And if not, well, the symbol update is correct regardlessSigned-off-by: Chris Perkins [email protected]