Skip to content

feat: handle grant spent amount calculation on payment completion #3674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 33 commits into
base: bc/raf-1031/grant-spent-amounts
Choose a base branch
from
+1,268 −15
Draft

feat: handle grant spent amount calculation on payment completion #3674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
9dbcfbe
feat: calculate grant spent amounts from new table
BlairCurrey Apr 28, 2025
d5f0f18
chore: linting
BlairCurrey Apr 28, 2025
511f66d
fix: revise grant spent amounts calc to track interval
BlairCurrey May 14, 2025
6a618db
fix: throw better error, dont inti interval amounts unless they exist
BlairCurrey May 14, 2025
bda9118
fix: linter, wip commented out code
BlairCurrey May 14, 2025
ab8097d
refactor(backend): rename interval statuses
BlairCurrey May 14, 2025
9395127
fix: ensure correct amount (interval/total) is used for grant spent a…
BlairCurrey May 14, 2025
4ba90ea
Merge branch 'bc/raf-1031/grant-spent-amounts' into blair/raf-1034
BlairCurrey May 15, 2025
e5ee133
test(backend): grant spent amounts
BlairCurrey May 15, 2025
934e9f6
fix(backend): make logic more typesafe, avoid having to defend w/ int…
BlairCurrey Jun 13, 2025
cf61c42
test(backend): legacy grant calculations
BlairCurrey Jun 24, 2025
eff27b1
test(backend): classify payment interval fn
BlairCurrey Jul 22, 2025
c42fc44
test(backend): rm commented-out classify payment interval case
BlairCurrey Jul 22, 2025
5f9630e
refactor(backend): improve semantics of interval helper fn
BlairCurrey Jul 23, 2025
6a11e97
test(backend): add non-interval cases to create op
BlairCurrey Jul 23, 2025
4773e69
Apply suggestions from code review
BlairCurrey Aug 11, 2025
add2084
Merge branch 'bc/raf-1031/grant-spent-amounts' into blair/raf-1036
BlairCurrey Aug 29, 2025
55333ac
feat: partially handled grant spent amount scenarios on settle
BlairCurrey Sep 30, 2025
2086256
feat: handle non-interval partial settleamount cases
BlairCurrey Oct 3, 2025
c63e1f9
test(backend): failure grant spent amount case for sucessive payment
BlairCurrey Oct 3, 2025
8dda943
test(backend): some grant calc interval cases
BlairCurrey Oct 6, 2025
e44178a
test(backend): counting grant payments across interval boundaries
BlairCurrey Oct 6, 2025
7e9cd30
chore(backend): rm commented out test
BlairCurrey Oct 6, 2025
500e1c7
test(backend): new grant spent amount on payment completion
BlairCurrey Oct 7, 2025
f42090c
test(backend): improve interval grant calc test to show summation
BlairCurrey Oct 7, 2025
138ab62
test(backend): failure edge case
BlairCurrey Oct 7, 2025
01ee666
chore(backend): rm comment
BlairCurrey Oct 7, 2025
81980a3
chore(backend): fix lint errors
BlairCurrey Oct 7, 2025
d88d99f
chore(backend): rm debug logs
BlairCurrey Oct 7, 2025
021e3ff
test(backend): fix failing
BlairCurrey Oct 7, 2025
4809df0
Update packages/backend/src/open_payments/payment/outgoing/lifecycle.ts
BlairCurrey Oct 7, 2025
c738d56
fix(backend): rm extra spent amount record check
BlairCurrey Oct 7, 2025
e9db95b
feat(backend): return debit amount from .pay
BlairCurrey Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions open-payments-specifications
Open in desktop
Submodule open-payments-specifications added at d0b86f
Loading
Loading