This repository was archived by the owner on Sep 24, 2021. It is now read-only.
feat(ios): use xcframework to include slices for all arch/flavor combinations #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
helenaford
approved these changes
Dec 31, 2020
|
Great, thanks for the review - I think @ajnozari said he'd test (when there's a chance, I mean obviously it's holidays everywhere) so I'm happy to wait for that for a merge in case I missed something. |
The xcframework structure allows for all execution architectures on all execution types to be supported, vs the single arch for all types limitations of the previous framework structure
helenaford
force-pushed
the
@helenaford/xcframework-draft
branch
from
4b044b3 to
e7bf416
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the new xcframework build work from the Notifee core library
It should support Apple Silicon or i386 or x86_64, for simulator or device or Mac Catalyst builds
Fixes #162, #215