Skip to content

Conversation

@technodelight
Copy link
Contributor

  • if magerun cache:flush runs
  • if admin is pressing on "flush magento cache"
  • if admin is pressing on "flush cache storage"

Then the DI container files should be removed accordingly.
This also fixes a bug when during capistrano deployments, the container were not cleaned up (as 99% of times only magerun cache:flush is called)

- if magerun cache:flush runs
- if admin is pressing on "flush magento cache"
- if admin is pressing on "flush cache storage"

Then the DI container files should be removed accordingly.
This also fixes a bug when during capistrano deployments, the container were not cleaned up (as 99% of times only magerun cache:flush is called)
unlink($metaFilePath);
}
$eventType = $event->getType();
if ($eventType === ConfigurationBuilder::MODEL_ALIAS || is_null($eventType)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can $eventType be null??

@jon-acker jon-acker merged commit 9e74e53 into inviqa:master Sep 19, 2016
@technodelight technodelight deleted the feature/fix-clearing-container-on-cache-flush branch September 19, 2016 12:52
@technodelight
Copy link
Contributor Author

thanks!

@jon-acker
Copy link
Contributor

thank you :)

On 19 September 2016 at 13:52, Zsolt Gál [email protected] wrote:

thanks!


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#11 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA6ZgGKv5EdcxKV7xNhk24Sl849duhQ1ks5qroWkgaJpZM4JuNrg
.


Jon Acker
Trainer

INVIQA
Business first
Telephone: +44 (0)203 1799 555
Mobile: +44 (0)796 334 6071
Web: inviqa.com

Inviqa is a unification of 3 companies - Session Digital, iKOS Digital and
Inviqa - that united in June 2016 to create a new multi-discipline
technology partner. Read more... http://inviqa.com/new-era

_Disclaimer:_This email and any attachments may be confidential and are
intended solely for the use of the addressee. Any views or opinions
expressed are those of the author and may not represent those of Inviqa. If
you are not the intended recipient of this email, you must neither take any
action based upon its contents, nor copy or show it to anyone. Please
contact the sender if you believe you have received this email in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants