feat(ui): respect aspect ratio when resizing bbox on canvas #8474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
hipsterusername
approved these changes
Aug 25, 2025
psychedelicious
force-pushed
the
psyche/fix/bbox-lock
branch
from
f742d4b to
525e74c
Compare
|
Shouldn’t this stay the way it is? I advocated for this behaviour before, before I knew that Shift key provided the functionality. So what does Shift key do now in locked mode? |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If the aspect ratio is locked, transforming bbox from Canvas maintains the selected aspect ratio. This uses an existing codepath - previously this behaviour was used only when holding shift.
Related Issues / Discussions
offline discussion
QA Instructions
n/a
Merge Plan
n/a
Checklist
What's Newcopy (if doing a release after this PR)