Skip to content

Conversation

@xXBJXx
Copy link
Contributor

@xXBJXx xXBJXx commented Dec 2, 2022

PR Checklist:

  • Provide a meaningful description to this PR or mention which issues this fixes.
  • Ensure the project builds with npm run build
  • Add tests for your change. This includes negative tests (i.e. inputs that need to fail) as well as baseline tests (i.e. how should the directory structure look like?).
  • Run the test suite with npm test
  • If there are baseline changes, review them and make a separate commit for them with the comment "accept baselines" if they are desired changes
  • If you added a required option, also add it to the template creation (.github/create_templates.ts)
  • Add a detailed migration description to docs/updates explaining what the user needs to do when manually updating an existing project
  • Add your changes to CHANGELOG.md (referencing the migration description and this PR or the issue you fixed)

Description:
add description here:

I have added the Ukrainian translation and the test has been OK so far, but to be on the safe side, please do a review.

@Apollon77 Apollon77 requested a review from AlCalzone December 8, 2022 22:40
@xXBJXx
Copy link
Contributor Author

xXBJXx commented Dec 11, 2022

I have fixed the problems that cause the tests to fail for everyone and Merged PR #1002 into my PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants