Skip to content

feat(angular): support autoMountComponent #25541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 28, 2022
Merged

feat(angular): support autoMountComponent #25541

merged 7 commits into from
Jun 28, 2022

Conversation

@liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jun 27, 2022 •
edited
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: Internal ticket.

What is the new behavior?

  • Adds support for autoMountComponent to Ionic Angular.
  • I also updated the popover-inline test to not automatically open the popover. This lets me test the autoMountComponent = false behavior.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi changed the title 1514 angular feat(angular): support autoMountComponent Jun 27, 2022
@github-actions github-actions bot added the package: angular @ionic/angular package label Jun 27, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review June 27, 2022 19:31
@liamdebeasi liamdebeasi requested a review from a team June 27, 2022 19:31
sean-perkins
sean-perkins suggested changes Jun 28, 2022
View reviewed changes
sean-perkins
sean-perkins approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@sean-perkins sean-perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Base automatically changed from 1514-base to FW-1514 June 28, 2022 15:57
@liamdebeasi liamdebeasi merged commit a6480a3 into FW-1514 Jun 28, 2022
@liamdebeasi liamdebeasi deleted the 1514-angular branch June 28, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@sean-perkins sean-perkins sean-perkins approved these changes

@averyjohnston averyjohnston averyjohnston approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

package: angular @ionic/angular package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liamdebeasi @sean-perkins @averyjohnston