Skip to content

Conversation

@bdeanindy
Copy link
Contributor

This should resolve #1110

@perrygovier
Copy link
Contributor

lgtm, note this is "below the fold". it won't be visible unless in the books section.

@perrygovier perrygovier merged commit e9180c5 into ionic-team:master May 22, 2017
@bdeanindy
Copy link
Contributor Author

I can adjust it to be above the fold (I see, you mean this (right):

191       <li ng-show="hash != 'books'">
192         <a href="#books" ng-click="hash = 'books'">More Books...</a>

@perrygovier
Copy link
Contributor

perrygovier commented May 22, 2017

yeah, you'd want to move it up above that line, move another book to be below the fold, and update the tags on each of the lis to match their respective new place.

@bdeanindy
Copy link
Contributor Author

I'll pull and make the change, then push it.

@bdeanindy
Copy link
Contributor Author

Any recommendations on which book should be moved down @perrygovier @mhartington @bensperry ???

@perrygovier
Copy link
Contributor

@mhartington would know best

@bdeanindy
Copy link
Contributor Author

@perrygovier Are we only ever allowed to have 6 books above the fold?

@perrygovier
Copy link
Contributor

it's an arbitrary number ben and I decided was how many you can have in the index list before things looked cluttered

@bdeanindy
Copy link
Contributor Author

Gotcha. Thanks.

@bdeanindy
Copy link
Contributor Author

Hey @gauravsaini03 Please see #1112 PR for the resolution to this. :)

@gauravsaini03-zz
Copy link

@bdeanindy 👍 Thanks for moving it upwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new book to Resources - Hybrid Mobile Development with Ionic

3 participants