Update menuToggle documentation #165
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi guys, First, love your framework. I'm developing in it right now and am shocked at how quickly one can scaffold together an application. Second, it seems that the way menu-toggle works right now is that it runs a $scope.$eval() in the content of the menu-toggle attribute, so it's expecting an angular expression. Leaving it just with quote works for the left side-menu, but adding menu-toggle="right" actually toggles the right-hand side menu as well. menu-toggle="'right'" works as expected, as does menu-toggle="'left'". I wasn't sure how much detail to put into the docs about this, but it seems like you don't delve a whole lot into the "why" in your other documentation, just the "how", so I went a little minimalist on my changes. Let me know if you'd prefer that I change something. Thanks again for your work! Ian
|
Hi @ianlyons , Thanks for the comments! We actually changed how the menu-toggle works in the nightly build (http://code.ionicframework.com/#nightly) - the $eval was a mistake! We will be pushing out a new stable release soon - these are the changes so far: http://code.ionicframework.com/nightly/CHANGELOG.html - this changelog is updated every commit. You can view nightly documentation at http://ionicframework.com/docs/nightly/api. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
First, love your framework. I'm developing in it right now and am shocked at how quickly one can scaffold together an application.
Second, it seems that the way menu-toggle works right now is that it runs a $scope.$eval() on the content of the menu-toggle attribute, so it's expecting an angular expression. Leaving it just with double-quotes works for the left side-menu, but adding menu-toggle="right" actually toggles the right-hand side menu as well. menu-toggle="'right'" works as expected, as does menu-toggle="'left'".
I wasn't sure how much detail to put into the docs about this, but it seems like you don't delve a whole lot into the "why" in your other documentation, just the "how", so I went a little minimalist on my changes. Let me know if you'd prefer that I change something.
Thanks again for your work!
Ian