feat: add ipni checks #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SgtPooki
commented
Sep 13, 2024
Member
Author
SgtPooki
left a comment
SgtPooki
left a comment
There was a problem hiding this comment.
still some commented out code to cleanup
2color
reviewed
Sep 16, 2024
aschmahmann
requested changes
Sep 17, 2024
Contributor
aschmahmann
left a comment
aschmahmann
left a comment
There was a problem hiding this comment.
Some tests will help flush out if things are properly covered here, but generally looks good aside from a few comments I made.
aschmahmann
requested changes
Sep 18, 2024
Contributor
aschmahmann
left a comment
aschmahmann
left a comment
There was a problem hiding this comment.
1 comment, but otherwise LGTM
aschmahmann
reviewed
Sep 18, 2024
Return HTTP 400 Bad Request error if user-supplied multiaddr is not valid.
aschmahmann
requested changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is still in progress and currently only outputs results of the indexer check to the console.
Next steps
Fixes #65