-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Description
Created as a follow-up for #10249, #9416, and a prerequisite for #8676
Problem
Right now, we support three values in Reprovider.Strategy which tells reprovider what should be announced. Valid strategies are:
- "all" - announce all stored data (this is also the implicit default)
- "pinned" - only announce pinned data
- "roots" - only announce directly pinned keys and root keys of recursive pins
If the repository gets too big, all and pinned are too expensive and folks are forced to use roots which is codec-agnostic and will only announce the root block of UnixFS DAG.
But roots comes with a big downside:
⚠️ BE CAREFUL: node withrootsstrategy will not announce child blocks.It makes sense only for use cases where the entire DAG is fetched in full, and a graceful resume does not have to be guaranteed: the lack of child announcements means an interrupted retrieval won't be able to find providers for the missing block in the middle of a file, unless the peer happens to already be connected to a provider and ask for child CID over bitswap.
This is not an inherent limitation of IPFS as a whole – it is only a limitation of how things are implemented in Kubo:
/ipfs/cid/sub/dir/fileis resolved first, into/ipfs/file-CID- Retrieval of
/ipfs/file-CIDstarts - If interrupted and resumed at later time, blocks for
/ipfs/cid,/ipfs/cid/sub, and/ipfs/cid/sub/dirare already cached in local store, so Kubo does no network lookup for provider of these. It will ask for providers of the first missing block within/ipfs/file-CID, and if these internal blocks are not announced (e.g. due toReprovider.Strategyset toroots), Kubo won't be able to resume download.
Solution ideas
- Every block requested by Kubo has some Content Path Affinity
- could be as simple as
/ipfs/CID(direct block get) - or more complex, as
/ipfs/cid/sub/dir/file(resuming retrieval from the middle of the file)
- could be as simple as
- Pass this affinity information around
- TBD: could be invasive change to all interfaces, or an optional hint passed in GO context
- 👉 Make retrieval code leverage Content Path Affinity when regular providers can't be found
- TBD: we want to balance speed vs avoiding bitswap spam.
- If no providers for internal block within
/ipfs/file-CIDcan be found, look for providers of parent entity (directory) CIDs (dir,suband finallycid). With each step growing the probability of finding one. Or we could always ask for leas and the most distant ones in parallel. Depends if we expect majority of data being announced asrootsorentities(Improved Reprovider.Strategy for entity DAGs (HAMT/UnixFS dirs, big files) #8676 (comment)) - Ideas welcome, but also an implementation detail.
- If no providers for internal block within
- TBD: we want to balance speed vs avoiding bitswap spam.