Don't rerun test with --lf it hides failures. #1324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carreau
force-pushed
the
no-lf
branch
3 times, most recently
from
04f99f1 to
b5de665
Compare
Carreau
changed the title
I think this is an anti patern,
1) we are already using flaky, so flaky test should be marked as such.
2) if it fails on first run and pass on --lf, this indicate that the
test are relying on a global state that should either:
- be investigated
- is known, and then should be given a specific marker to be ran
separately.
The only advantage is to delay finding issues.
Member
Author
|
Ok, It's annoying to wait. |
ianthomas23
pushed a commit
to ianthomas23/ipykernel
that referenced
this pull request
May 23, 2025
ianthomas23
pushed a commit
to ianthomas23/ipykernel
that referenced
this pull request
Jul 15, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is an anti pattern,
we are already using flaky, so flaky test should be marked as such.
if it fails on first run and pass on --lf, this indicate that the
test are relying on a global state that should either:
in addition:
--lfreruns the test without qt5 or qt6, so don't actually rerun many test.So this is actually bad as it hides errors.
If at least it was
cov:test||cov:test --lfit would make more sens, but here it's plainly wrong.--
This is just a suggestion and my reasoning. See #1323, and thanks to @davidbrochart for pointing out that there was the --lf.