Unaryops #46
Closed
Unaryops #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
reviewed
Dec 15, 2022
| PyObject *tmp = REG(oparg2); | ||
| REG(oparg2) = res; | ||
| Py_XDECREF(tmp); | ||
| ERROR_IF(res == NULL, error); |
There was a problem hiding this comment.
Why destroy the register before jumping to the error label?
Also, Isn't there a macro Py_SETREF() that does the little dance with the temp variable and the XDECREF?
Owner
Author
There was a problem hiding this comment.
Thanks, I forgot what it was called. Everything here is now on the new PR (on today's main). So I can close this one and we only have one on the go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.