Adds new Collision Mesh Schema properties #2249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellyguo11
changed the title
|
A bunch of tests seem to be failing on this one, @jsmith-bdai would you mind taking a look? |
Test Results Summary1 726 tests 1 723 ✅ 1h 2m 23s ⏱️ For more details on these errors, see this check. Results for commit 72871fd. ♻️ This comment has been updated with latest results. |
Added to contributors list Signed-off-by: Harsh Patel <[email protected]>
Signed-off-by: Harsh Patel <[email protected]>
Signed-off-by: Harsh Patel <[email protected]>
jtigue-bdai
force-pushed
the
hapatel/collision_mesh_schema
branch
from
f302994 to
fcd8b98
Compare
|
@kellyguo11 reopening |
|
ah sorry, I think it got closed when I renamed the branch...let's just keep this branch then |
kellyguo11
approved these changes
Sep 9, 2025
kellyguo11
added a commit
that referenced
this pull request
Sep 9, 2025
# Description Adding new collision mesh property options allowing users to configure meshes to add different collision types ## Type of change - New feature (non-breaking change which adds functionality) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: Harsh Patel <[email protected]> Co-authored-by: James Tigue <[email protected]> Co-authored-by: James Tigue <[email protected]> Co-authored-by: Kelly Guo <[email protected]>
ooctipus
pushed a commit
to ooctipus/IsaacLab
that referenced
this pull request
Sep 20, 2025
# Description Adding new collision mesh property options allowing users to configure meshes to add different collision types ## Type of change - New feature (non-breaking change which adds functionality) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: Harsh Patel <[email protected]> Co-authored-by: James Tigue <[email protected]> Co-authored-by: James Tigue <[email protected]> Co-authored-by: Kelly Guo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding new collision mesh property options allowing users to configure meshes to add different collision types
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there