Adds logdir configuration parameter to environments #3391
Merged
+43
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellyguo11
requested review from
Mayankm96,
jtigue-bdai and
ooctipus
as code owners
ooctipus
approved these changes
Sep 8, 2025
Mayankm96
reviewed
Sep 9, 2025
source/isaaclab_tasks/isaaclab_tasks/direct/shadow_hand/feature_extractor.py
Outdated
Show resolved
Hide resolved
Mayankm96
reviewed
Sep 9, 2025
source/isaaclab_tasks/isaaclab_tasks/direct/shadow_hand/feature_extractor.py
Outdated
Show resolved
Hide resolved
…e_extractor.py Co-authored-by: Mayank Mittal <[email protected]> Signed-off-by: Kelly Guo <[email protected]>
…e_extractor.py Co-authored-by: Mayank Mittal <[email protected]> Signed-off-by: Kelly Guo <[email protected]>
Signed-off-by: Kelly Guo <[email protected]>
Mayankm96
approved these changes
Sep 10, 2025
kellyguo11
added a commit
that referenced
this pull request
Sep 11, 2025
# Description Adds a logdir parameter for all environment configs to allow passing of the log dir for each experiment from the training/inferencing scripts to the environment object. This allows environments to access the logdir for the run and store log files in there, such as from the feature extractor. ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> --------- Signed-off-by: Kelly Guo <[email protected]> Signed-off-by: Kelly Guo <[email protected]> Co-authored-by: Mayank Mittal <[email protected]>
ooctipus
pushed a commit
to ooctipus/IsaacLab
that referenced
this pull request
Sep 20, 2025
# Description Adds a logdir parameter for all environment configs to allow passing of the log dir for each experiment from the training/inferencing scripts to the environment object. This allows environments to access the logdir for the run and store log files in there, such as from the feature extractor. ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> --------- Signed-off-by: Kelly Guo <[email protected]> Signed-off-by: Kelly Guo <[email protected]> Co-authored-by: Mayank Mittal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a logdir parameter for all environment configs to allow passing of the log dir for each experiment from the training/inferencing scripts to the environment object.
This allows environments to access the logdir for the run and store log files in there, such as from the feature extractor.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there