fix: correct regex pattern for non-printable characters #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on code style consistency and modernization across several vendored standard library modules. The main changes involve switching string literals from single quotes to double quotes, updating Unicode literal usage for Python 3, improving readability, and making minor formatting adjustments. These changes do not alter functionality but improve code clarity and maintainability.
String Literal and Formatting Consistency:
metaflow/_vendor/imghdr/__init__.py
andmetaflow/_vendor/importlib_metadata/__init__.py
, as well as in various string operations and comparisons. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17]Python 3 Modernization:
u"..."
) and replaced them with standard string literals, as Python 3 uses Unicode strings by default. This affects control character handling and message formatting inmetaflow/_vendor/click/_termui_impl.py
andmetaflow/_vendor/click/utils.py
. [1] [2] [3]Readability and Formatting Improvements:
if
statements and aligning argument lists. [1] [2]Minor Logic and Clean-up:
These changes collectively make the vendored codebase more maintainable and consistent with modern Python standards, without introducing behavioral changes.