Handle environments without Git with a helpful error message #628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x2b3bfa0
changed the title
casperdcl
reviewed
Jul 1, 2021
| if (!repo) repo = gitRemoteUrl(); | ||
| } catch (err) { | ||
| err.message += | ||
| ', you might need to manually specify the --repo option or install Git'; |
Contributor
There was a problem hiding this comment.
super minor: maybe newline instead of ', '
Member
Author
There was a problem hiding this comment.
@DavidGOrtega asked me to let him solve #618 by replacing the git command-line tool by a JavaScript library, so I have closed this pull request. Nevertheless, your comment is still on topic and useful. Can you please move it to #606?
Member
Author
There was a problem hiding this comment.
Historical note: allegedly, this pull request was closed in favor of a then nonexistent #1003.
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.