Skip to content

Conversation

dacbd
Copy link
Contributor

@dacbd dacbd commented Apr 14, 2022

I am satisfied with the additional testing I have done.

@dacbd dacbd self-assigned this Apr 14, 2022
@dacbd dacbd marked this pull request as ready for review April 19, 2022 01:54
@dacbd dacbd requested review from DavidGOrtega and casperdcl April 19, 2022 01:54
@dacbd
Copy link
Contributor Author

dacbd commented Apr 19, 2022 via email

dacbd and others added 2 commits April 19, 2022 22:42
Co-authored-by: Helio Machado <[email protected]>
@0x2b3bfa0
Copy link
Member

0x2b3bfa0 commented Apr 19, 2022

I'd prefer to keep the scope as local as possible for now, given that #461 may deduplicate1 some legacy code, and it may be easier to migrate the relevant portions than to import them from the “utils” 42–ish package.

Footnotes

  1. Blatantly obvious euphemism for obliterate

@dacbd
Copy link
Contributor Author

dacbd commented Apr 19, 2022

Works for me, I will de-utils some of these gcp functions.

@dacbd dacbd requested a review from 0x2b3bfa0 April 19, 2022 15:04
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@0x2b3bfa0 0x2b3bfa0 added the enhancement New feature or request label Apr 19, 2022
@0x2b3bfa0 0x2b3bfa0 added security Sensitive flaws cloud-gcp Google Cloud labels Apr 19, 2022
@0x2b3bfa0 0x2b3bfa0 merged commit e453ea7 into master Apr 19, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the gcp-oidc branch April 19, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cloud-gcp Google Cloud enhancement New feature or request security Sensitive flaws

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants