If line.start <=0 then continue replacing whitespaces otherwise it is…

[hady-malekpour]

If line.start <=0 then continue replacing whitespaces otherwise it is a GlyphLine which has been created from existing one

Please also check this question: https://stackoverflow.com/questions/56270373/generating-pdf-with-large-number-of-characters-is-taking-long

[avlemos]

hi @hady-malekpour,

We have added your contribution into our backlog so it gets analyzed by our developers.

Thank you

[ars18wrw]

Hi @hady-malekpour!

First of all, thank you for your contribution! Unfortunately, the appropriate SO questions was deleted, although I do remember it partially. So could you add a test which demonstrates what is the issue about? Once the test is commited, could you squash the commits, so that there is only one commit in the end?

Best regards,
Uladzimir Asipchuk.

[introfog]

Hi, @hady-malekpour, thank your for your PR!

We reviewed your pull request and as far as we understand your suggested fix should improve the performance when long text is split across many lines. We have implemented same idea but in a bit different approach in commit 495f172 to make sure that various flows operate correctly. Namely, GlyphLine can be set to TextRenderer during its lifecycle and line.start <= 0 might not be a correct check in this case.

Anyway, thanks for the contribution and sorry for the delay.