fix incorrect typings for compile get/set methods #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is demonstrably not correct: |
|
Hi @janl Thank you for the feedback. However, I think the PR should be reopened, you are looking at the incorrect lines. Yes, the get/set functions themselves and typings are correct. This PR does not change the typings for those functions, as they are already correct. The typings for get/set methods on the compile function however are not correct - these accept 1 and 2 parameters respectively; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typings for get/set methods for compile are incorrect. The set method only accepts 1 param, and set method only accepts 2 params.
This PR fixes the typings for get/set method for compile function.