Skip to content

Conversation

@locene
Copy link
Contributor

@locene locene commented May 3, 2024

… ioredis-yet

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

The solution to #669, this issue had been a major time drain for me 🙁

All test cases have passed.

 Test Files  1 passed (1)
      Tests  44 passed (44)
   Start at  12:31:22
   Duration  2.96s (transform 134ms, setup 0ms, collect 207ms, tests 2.38s, environment 0ms, prepare 118ms)

 % Coverage report from v8
----------|---------|----------|---------|---------|-------------------
File      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
----------|---------|----------|---------|---------|-------------------
All files |   95.48 |    93.87 |     100 |   95.48 |
 index.ts |   95.48 |    93.87 |     100 |   95.48 | 68-69,117-120
----------|---------|----------|---------|---------|-------------------

@jaredwray jaredwray merged commit 9647acf into jaredwray:main May 6, 2024
@jaredwray
Copy link
Owner

@locene - this will be deployed in the next two weeks.

@Kauhsa Kauhsa mentioned this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants