Remove unnecessary .js files #4083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example code in documentation/coffee/*.coffee accidentally had duplicate compiled .js versions committed: Both as documentation/js/*.js and as documentation/coffee/*.js. The former is generated when running `cake doc:site`, while the latter has no cake task to be generated. Removing the former and then re-compiling index.html results in all the code examples being missing in the resulting HTML, while removing the latter makes no difference. In conclusion, documentation/coffee/*.js must be the unnecessary duplicates. They are removed by this commit.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example code in documentation/coffee/.coffee accidentally had duplicate
compiled .js versions committed: Both as documentation/js/.js and as
documentation/coffee/*.js.
The former is generated when running
cake doc:site, while the latter has nocake task to be generated. Removing the former and then re-compiling index.html
results in all the code examples being missing in the resulting HTML, while
removing the latter makes no difference.
In conclusion, documentation/coffee/*.js must be the unnecessary duplicates.
They are removed by this commit.