Skip to content

[CS2] Fix #4577; renamed destructured parameters with same default value #4596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2017
Merged

[CS2] Fix #4577; renamed destructured parameters with same default value #4596

merged 1 commit into from
Jul 6, 2017

Conversation

@zdenko
Copy link
Collaborator

@zdenko zdenko commented Jul 1, 2017

This PR fixes issue #4577.
Renamed destructured parameters with the same default value produced a compilation error:
multiple parameters named 0.

({ a: aa = 0, b: bb = 0 }) ->
  "#{aa}, #{bb}"

@GeoffreyBooth GeoffreyBooth merged commit 35eb58f into jashkenas:2 Jul 6, 2017
@GeoffreyBooth
Copy link
Collaborator

GeoffreyBooth commented Jul 6, 2017

Great, thanks!

@GeoffreyBooth GeoffreyBooth deleted the renamed-destructured-parameters branch July 6, 2017 02:05
@GeoffreyBooth GeoffreyBooth mentioned this pull request Jul 6, 2017
Closed
@GeoffreyBooth GeoffreyBooth mentioned this pull request Aug 4, 2017
Closed
@GeoffreyBooth GeoffreyBooth modified the milestone: 2.0.0 Aug 14, 2017
@coffeescriptbot coffeescriptbot mentioned this pull request Feb 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@zdenko @GeoffreyBooth