Move sourceMappingURL to last line #5237
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess? Would this be a breaking change for anyone? |
|
Going on a limb here - it's been a few years - but wasn't there some I.E. bug if the last line contained some specific characters that could pose an issue? Maybe we don't need to care, to be fair... |
3 tasks
|
Is this good to merge? |
|
Any update on this? |
|
I don’t know what to do with this. I worry that it could break some people, like bundlers that expect the current output, and I don’t really see why the change is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more in line with the spec which says "the generated code may include a line at the end of the source, with the following form:
//# sourceMappingURL=<url>" and "there exists a//# sourceURLcomment in the generated code". It also looks better since thesourceMappingURLis very long. Also, add a trailing newline. This was motivated by mishoo/UglifyJS#3441.