Convert com.facebook.react.bridge.ReadableNativeArray to Kotlin (facebook#47484)

Summary:
Pull Request resolved: facebook#47484

Small change to types in the base class: all non-primitives return optional from ReadableArray, which matches the semantics in ReadableMap. We already rely on this in some cases, but the current nullability annotations were incorrect, and null values from the array would be passed through from `getMap` and `getArray`.

Changelog: [Internal]

Differential Revision: D65596278

Author: javache

packages/react-native/ReactAndroid/api/ReactAndroid.api

@@ -1481,7 +1481,7 @@ public class com/facebook/react/bridge/ReadableNativeArray : com/facebook/react/
 	public fun getDouble (I)D
 	public fun getDynamic (I)Lcom/facebook/react/bridge/Dynamic;
 	public fun getInt (I)I
-	public static fun getJNIPassCounter ()I
+	public static final fun getJNIPassCounter ()I
 	public fun getLong (I)J
 	public synthetic fun getMap (I)Lcom/facebook/react/bridge/ReadableMap;
 	public fun getMap (I)Lcom/facebook/react/bridge/ReadableNativeMap;

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/animated/InterpolationAnimatedNode.kt

@@ -130,7 +130,7 @@ public class InterpolationAnimatedNode(config: ReadableMap) : ValueAnimatedNode(
       val outputRange = arrayOfNulls<DoubleArray>(size)
 
       // Match the first pattern into a List, since we don't know its length yet
-      var m = numericPattern.matcher(array.getString(0))
+      var m = numericPattern.matcher(array.getString(0) ?: "")
       val firstOutputRange: MutableList<Double> = ArrayList()
       while (m.find()) {
         firstOutputRange.add(m.group().toDouble())
@@ -143,7 +143,7 @@ public class InterpolationAnimatedNode(config: ReadableMap) : ValueAnimatedNode(
       for (i in 1 until size) {
         val outputArr = DoubleArray(firstOutputRangeArr.size)
         var j = 0
-        m = numericPattern.matcher(array.getString(i))
+        m = numericPattern.matcher(array.getString(i) ?: "")
         while (m.find() && j < firstOutputRangeArr.size) {
           outputArr[j++] = m.group().toDouble()
         }

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/animated/ObjectAnimatedNode.kt

@@ -45,7 +45,9 @@ internal class ObjectAnimatedNode(
         ReadableType.String -> result.pushString(source.getString(i))
         ReadableType.Map -> {
           val map = source.getMap(i)
-          if (map.hasKey(NODE_TAG_KEY) && map.getType(NODE_TAG_KEY) == ReadableType.Number) {
+          if (map != null &&
+              map.hasKey(NODE_TAG_KEY) &&
+              map.getType(NODE_TAG_KEY) == ReadableType.Number) {
             val node = nativeAnimatedNodesManager.getNodeById(map.getInt(NODE_TAG_KEY))
             requireNotNull(node) { "Mapped value node does not exist" }
             if (node is ValueAnimatedNode) {

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/animated/TransformAnimatedNode.kt

@@ -27,7 +27,7 @@ internal class TransformAnimatedNode(
         if (transforms == null) mutableListOf()
         else
             MutableList<TransformConfig>(transforms.size()) { i ->
-              val transformConfigMap = transforms.getMap(i)
+              val transformConfigMap = transforms.getMap(i)!!
               val property = transformConfigMap.getString("property")
               val type = transformConfigMap.getString("type")
               if (type == "animated") {

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/ColorPropConverter.java

@@ -34,7 +34,7 @@ private static boolean supportWideGamut() {
   private static final String ATTR_SEGMENT = "attr/";
 
   @Nullable
-  private static Integer getColorInteger(Object value, Context context) {
+  private static Integer getColorInteger(@Nullable Object value, Context context) {
     if (value == null) {
       return null;
     }
@@ -84,7 +84,7 @@ private static Integer getColorInteger(Object value, Context context) {
   }
 
   @Nullable
-  public static Color getColorInstance(Object value, Context context) {
+  public static Color getColorInstance(@Nullable Object value, Context context) {
     if (value == null) {
       return null;
     }
@@ -136,7 +136,7 @@ public static Color getColorInstance(Object value, Context context) {
         "ColorValue: the value must be a number or Object.");
   }
 
-  public static Integer getColor(Object value, Context context) {
+  public static Integer getColor(@Nullable Object value, Context context) {
     try {
       if (supportWideGamut()) {
         Color color = getColorInstance(value, context);
@@ -150,7 +150,7 @@ public static Integer getColor(Object value, Context context) {
     return getColorInteger(value, context);
   }
 
-  public static Integer getColor(Object value, Context context, int defaultInt) {
+  public static Integer getColor(@Nullable Object value, Context context, int defaultInt) {
     try {
       return getColor(value, context);
     } catch (JSApplicationCausedNativeException e) {

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/JavaOnlyArray.kt

@@ -73,13 +73,13 @@ public class JavaOnlyArray : ReadableArray, WritableArray {
 
   override fun getLong(index: Int): Long = (backingList[index] as Number).toLong()
 
-  override fun getString(index: Int): String = backingList[index] as String
+  override fun getString(index: Int): String? = backingList[index] as String?
 
-  override fun getArray(index: Int): ReadableArray = backingList[index] as ReadableArray
+  override fun getArray(index: Int): ReadableArray? = backingList[index] as ReadableArray?
 
   override fun getBoolean(index: Int): Boolean = backingList[index] as Boolean
 
-  override fun getMap(index: Int): ReadableMap = backingList[index] as ReadableMap
+  override fun getMap(index: Int): ReadableMap? = backingList[index] as ReadableMap?
 
   override fun getDynamic(index: Int): Dynamic = DynamicFromArray.create(this, index)
 

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/ReadableArray.kt

@@ -14,7 +14,7 @@ import java.util.ArrayList
  * to Kotlin.
  */
 public interface ReadableArray {
-  public fun getArray(index: Int): ReadableArray
+  public fun getArray(index: Int): ReadableArray?
 
   public fun getBoolean(index: Int): Boolean
 
@@ -26,9 +26,9 @@ public interface ReadableArray {
 
   public fun getLong(index: Int): Long
 
-  public fun getMap(index: Int): ReadableMap
+  public fun getMap(index: Int): ReadableMap?
 
-  public fun getString(index: Int): String
+  public fun getString(index: Int): String?
 
   public fun getType(index: Int): ReadableType
 

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/ReadableNativeArray.java

@@ -0,0 +1,92 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+package com.facebook.react.bridge
+
+import com.facebook.proguard.annotations.DoNotStrip
+import java.util.ArrayList
+import java.util.Arrays
+import kotlin.jvm.JvmStatic
+
+/**
+ * Implementation of a NativeArray that allows read-only access to its members. This will generally
+ * be constructed and filled in native code so you shouldn't construct one yourself.
+ */
+@DoNotStrip
+public open class ReadableNativeArray protected constructor() : NativeArray(), ReadableArray {
+
+  private val localArray: Array<Any?> by
+      lazy(LazyThreadSafetyMode.SYNCHRONIZED) {
+        jniPassCounter++
+        importArray()
+      }
+
+  private external fun importArray(): Array<Any?>
+
+  private val localTypeArray: Array<ReadableType> by
+      lazy(LazyThreadSafetyMode.SYNCHRONIZED) {
+        jniPassCounter++
+        val tempArray = importTypeArray()
+        Arrays.copyOf(tempArray, tempArray.size, Array<ReadableType>::class.java)
+      }
+
+  private external fun importTypeArray(): Array<Any>
+
+  override fun size(): Int = localArray.size
+
+  override fun isNull(index: Int): Boolean = localArray[index] == null
+
+  override fun getBoolean(index: Int): Boolean = localArray[index] as Boolean
+
+  override fun getDouble(index: Int): Double = localArray[index] as Double
+
+  override fun getInt(index: Int): Int = (localArray[index] as Double).toInt()
+
+  override fun getLong(index: Int): Long = localArray[index] as Long
+
+  override fun getString(index: Int): String? = localArray[index] as String?
+
+  override fun getArray(index: Int): ReadableNativeArray? =
+      localArray[index] as ReadableNativeArray?
+
+  override fun getMap(index: Int): ReadableNativeMap? = localArray[index] as ReadableNativeMap?
+
+  override fun getType(index: Int): ReadableType = localTypeArray[index]
+
+  override fun getDynamic(index: Int): Dynamic = DynamicFromArray.create(this, index)
+
+  override fun hashCode(): Int = localArray.hashCode()
+
+  override fun equals(other: Any?): Boolean {
+    if (other !is ReadableNativeArray) {
+      return false
+    }
+    return localArray.contentDeepEquals(other.localArray)
+  }
+
+  override fun toArrayList(): ArrayList<Any?> {
+    val arrayList = ArrayList<Any?>()
+    repeat(size()) { i ->
+      when (getType(i)) {
+        ReadableType.Null -> arrayList.add(null)
+        ReadableType.Boolean -> arrayList.add(getBoolean(i))
+        ReadableType.Number -> arrayList.add(getDouble(i))
+        ReadableType.String -> arrayList.add(getString(i))
+        ReadableType.Map -> arrayList.add(getMap(i)?.toHashMap())
+        ReadableType.Array -> arrayList.add(getArray(i)?.toArrayList())
+      }
+    }
+    return arrayList
+  }
+
+  private companion object {
+    @get:JvmStatic
+    @get:JvmName("getJNIPassCounter")
+    public var jniPassCounter: Int = 0
+      private set
+  }
+}