Convert com.facebook.react.bridge.ReadableNativeArray to Kotlin #47484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65596278 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65596278 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Nov 7, 2024
…book#47484) Summary: Pull Request resolved: facebook#47484 Changelog: [Internal] Differential Revision: D65596278
javache
force-pushed
the
export-D65596278
branch
from
10c6576 to
74cbf5c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65596278 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Nov 19, 2024
…book#47484) Summary: Pull Request resolved: facebook#47484 Small change to types in the base class: all non-primitives return optional from ReadableArray, which matches the semantics in ReadableMap. We already rely on this in some cases, but the current nullability annotations were incorrect, and null values from the array would be passed through from `getMap` and `getArray`. Changelog: [Internal] Differential Revision: D65596278
javache
force-pushed
the
export-D65596278
branch
from
74cbf5c to
203def5
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Nov 19, 2024
…book#47484) Summary: Pull Request resolved: facebook#47484 Changelog: [Internal] Differential Revision: D65596278
javache
added a commit
to javache/react-native
that referenced
this pull request
Nov 19, 2024
…book#47484) Summary: Pull Request resolved: facebook#47484 Changelog: [Internal] Differential Revision: D65596278
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65596278 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Nov 20, 2024
…book#47484) Summary: Pull Request resolved: facebook#47484 Small change to types in the base class: all non-primitives return optional from ReadableArray, which matches the semantics in ReadableMap. We already rely on this in some cases, but the current nullability annotations were incorrect, and null values from the array would be passed through from `getMap` and `getArray`. Changelog: [Android][Breaking] ReadableArray non-primitive getters are now correctly typed as optional Differential Revision: D65596278
javache
force-pushed
the
export-D65596278
branch
from
203def5 to
302cd09
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65596278 |
javache
force-pushed
the
export-D65596278
branch
from
302cd09 to
2a79306
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Nov 21, 2024
…book#47484) Summary: Pull Request resolved: facebook#47484 Small change to types in the base class: all non-primitives return optional from ReadableArray, which matches the semantics in ReadableMap. We already rely on this in some cases, but the current nullability annotations were incorrect, and null values from the array would be passed through from `getMap` and `getArray`. Changelog: [Android][Breaking] ReadableArray non-primitive getters are now correctly typed as optional Differential Revision: D65596278
javache
added a commit
to javache/react-native
that referenced
this pull request
Nov 21, 2024
…book#47484) Summary: Pull Request resolved: facebook#47484 Changelog: [Internal] Differential Revision: D65596278
…book#47484) Summary: Pull Request resolved: facebook#47484 Small change to types in the base class: all non-primitives return optional from ReadableArray, which matches the semantics in ReadableMap. We already rely on this in some cases, but the current nullability annotations were incorrect, and null values from the array would be passed through from `getMap` and `getArray`. Changelog: [Android][Breaking] ReadableArray non-primitive getters are now correctly typed as optional Reviewed By: Abbondanzo Differential Revision: D65596278
javache
force-pushed
the
export-D65596278
branch
from
2a79306 to
4091520
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65596278 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Nov 21, 2024
…book#47484) Summary: Pull Request resolved: facebook#47484 Changelog: [Internal] Differential Revision: D65596278
Contributor
|
This pull request has been merged in 145c72f. |
Collaborator
|
This pull request was successfully merged by @javache in 145c72f When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Changelog: [Internal]
Differential Revision: D65596278