Skip to content

style: Style/SpecialGlobalVars #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2020
Merged

style: Style/SpecialGlobalVars #216

merged 1 commit into from
Apr 13, 2020

Conversation

@DirtyF
Copy link
Member

@DirtyF DirtyF commented Apr 13, 2020

@DirtyF DirtyF requested a review from a team April 13, 2020 12:07
@ashmaroli
Copy link
Member

ashmaroli commented Apr 13, 2020

Or how about redefining it to be similar to jekyll.gemspec:

-   spec.files         = `git ls-files`.split($/)
+   spec.files         = `git ls-files`.split("\x0")

@DirtyF
Copy link
Member Author

DirtyF commented Apr 13, 2020

Much more readable in English IMO

@DirtyF
Copy link
Member Author

DirtyF commented Apr 13, 2020 •
edited
Loading

@jekyll: merge +style

@jekyllbot jekyllbot merged commit e4fb738 into master Apr 13, 2020
@jekyllbot jekyllbot deleted the style/SpecialGlobalVars branch April 13, 2020 13:18
jekyllbot added a commit that referenced this pull request Apr 13, 2020
@jekyllbot
Update history to reflect merge of #216 [ci skip]
d1ccfdf
@jekyll jekyll locked and limited conversation to collaborators Dec 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ashmaroli ashmaroli ashmaroli approved these changes

Assignees

No one assigned

Labels

frozen-due-to-age style tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DirtyF @ashmaroli @jekyllbot