Skip to content

generated floating deps test must ignore lockfile #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 7, 2021
Merged

generated floating deps test must ignore lockfile #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb8b3b6
generated floating deps test must ignore lockfile
jelhan Jan 7, 2021
f9a1dd7
must always install dependencies for floating deps test
jelhan Jan 7, 2021
57c7b02
update snapshots
jelhan Jan 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions templates/.github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,26 +175,17 @@ jobs:
path: |
${{ steps.global-cache-dir-path.outputs.dir }}
node_modules
key: ${{ runner.os }}-${{ matrix.node-version }}-${{
hashFiles('**/<%
if (packageManager === 'npm') {
%>package-lock.json<%
} else {
%>yarn.lock<%
} %>'
) }}
key: ${{ runner.os }}-${{ matrix.node-version }}-floating-deps
restore-keys: |
${{ runner.os }}-${{ matrix.node-version }}-

- name: Install Dependencies
run: <%
if (packageManager === 'npm') {
%>npm ci<%
%>npm install --no-package-lock<%
} else {
%>yarn install --frozen-lockfile<%
%>yarn install --no-lockfile --non-interactive<%
} %>
if: |
steps.cache-dependencies.outputs.cache-hit != 'true'

- name: Test
run: <% if (packageManager === 'npm') { %>npm run-script<% } else { %>yarn<% } %> test:ember --launch ${{ matrix.browser }}
Expand Down
104 changes: 26 additions & 78 deletions tests/acceptance/__snapshots__/creates-github-actions.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,16 +159,12 @@ jobs:
path: |
\${{ steps.global-cache-dir-path.outputs.dir }}
node_modules
key: \${{ runner.os }}-\${{ matrix.node-version }}-\${{
hashFiles('**/package-lock.json'
) }}
key: \${{ runner.os }}-\${{ matrix.node-version }}-floating-deps
restore-keys: |
\${{ runner.os }}-\${{ matrix.node-version }}-

- name: Install Dependencies
run: npm ci
if: |
steps.cache-dependencies.outputs.cache-hit != 'true'
run: npm install --no-package-lock

- name: Test
run: npm run-script test:ember --launch \${{ matrix.browser }}
Expand Down Expand Up @@ -392,16 +388,12 @@ jobs:
path: |
\${{ steps.global-cache-dir-path.outputs.dir }}
node_modules
key: \${{ runner.os }}-\${{ matrix.node-version }}-\${{
hashFiles('**/package-lock.json'
) }}
key: \${{ runner.os }}-\${{ matrix.node-version }}-floating-deps
restore-keys: |
\${{ runner.os }}-\${{ matrix.node-version }}-

- name: Install Dependencies
run: npm ci
if: |
steps.cache-dependencies.outputs.cache-hit != 'true'
run: npm install --no-package-lock

- name: Test
run: npm run-script test:ember --launch \${{ matrix.browser }}
Expand Down Expand Up @@ -625,16 +617,12 @@ jobs:
path: |
\${{ steps.global-cache-dir-path.outputs.dir }}
node_modules
key: \${{ runner.os }}-\${{ matrix.node-version }}-\${{
hashFiles('**/package-lock.json'
) }}
key: \${{ runner.os }}-\${{ matrix.node-version }}-floating-deps
restore-keys: |
\${{ runner.os }}-\${{ matrix.node-version }}-

- name: Install Dependencies
run: npm ci
if: |
steps.cache-dependencies.outputs.cache-hit != 'true'
run: npm install --no-package-lock

- name: Test
run: npm run-script test:ember --launch \${{ matrix.browser }}
Expand Down Expand Up @@ -860,16 +848,12 @@ jobs:
path: |
\${{ steps.global-cache-dir-path.outputs.dir }}
node_modules
key: \${{ runner.os }}-\${{ matrix.node-version }}-\${{
hashFiles('**/package-lock.json'
) }}
key: \${{ runner.os }}-\${{ matrix.node-version }}-floating-deps
restore-keys: |
\${{ runner.os }}-\${{ matrix.node-version }}-

- name: Install Dependencies
run: npm ci
if: |
steps.cache-dependencies.outputs.cache-hit != 'true'
run: npm install --no-package-lock

- name: Test
run: npm run-script test:ember --launch \${{ matrix.browser }}
Expand Down Expand Up @@ -1096,16 +1080,12 @@ jobs:
path: |
\${{ steps.global-cache-dir-path.outputs.dir }}
node_modules
key: \${{ runner.os }}-\${{ matrix.node-version }}-\${{
hashFiles('**/package-lock.json'
) }}
key: \${{ runner.os }}-\${{ matrix.node-version }}-floating-deps
restore-keys: |
\${{ runner.os }}-\${{ matrix.node-version }}-

- name: Install Dependencies
run: npm ci
if: |
steps.cache-dependencies.outputs.cache-hit != 'true'
run: npm install --no-package-lock

- name: Test
run: npm run-script test:ember --launch \${{ matrix.browser }}
Expand Down Expand Up @@ -1334,16 +1314,12 @@ jobs:
path: |
\${{ steps.global-cache-dir-path.outputs.dir }}
node_modules
key: \${{ runner.os }}-\${{ matrix.node-version }}-\${{
hashFiles('**/yarn.lock'
) }}
key: \${{ runner.os }}-\${{ matrix.node-version }}-floating-deps
restore-keys: |
\${{ runner.os }}-\${{ matrix.node-version }}-

- name: Install Dependencies
run: yarn install --frozen-lockfile
if: |
steps.cache-dependencies.outputs.cache-hit != 'true'
run: yarn install --no-lockfile --non-interactive

- name: Test
run: yarn test:ember --launch \${{ matrix.browser }}
Expand Down Expand Up @@ -1569,16 +1545,12 @@ jobs:
path: |
\${{ steps.global-cache-dir-path.outputs.dir }}
node_modules
key: \${{ runner.os }}-\${{ matrix.node-version }}-\${{
hashFiles('**/package-lock.json'
) }}
key: \${{ runner.os }}-\${{ matrix.node-version }}-floating-deps
restore-keys: |
\${{ runner.os }}-\${{ matrix.node-version }}-

- name: Install Dependencies
run: npm ci
if: |
steps.cache-dependencies.outputs.cache-hit != 'true'
run: npm install --no-package-lock

- name: Test
run: npm run-script test:ember --launch \${{ matrix.browser }}
Expand Down Expand Up @@ -1804,16 +1776,12 @@ jobs:
path: |
\${{ steps.global-cache-dir-path.outputs.dir }}
node_modules
key: \${{ runner.os }}-\${{ matrix.node-version }}-\${{
hashFiles('**/yarn.lock'
) }}
key: \${{ runner.os }}-\${{ matrix.node-version }}-floating-deps
restore-keys: |
\${{ runner.os }}-\${{ matrix.node-version }}-

- name: Install Dependencies
run: yarn install --frozen-lockfile
if: |
steps.cache-dependencies.outputs.cache-hit != 'true'
run: yarn install --no-lockfile --non-interactive

- name: Test
run: yarn test:ember --launch \${{ matrix.browser }}
Expand Down Expand Up @@ -2027,16 +1995,12 @@ jobs:
path: |
\${{ steps.global-cache-dir-path.outputs.dir }}
node_modules
key: \${{ runner.os }}-\${{ matrix.node-version }}-\${{
hashFiles('**/yarn.lock'
) }}
key: \${{ runner.os }}-\${{ matrix.node-version }}-floating-deps
restore-keys: |
\${{ runner.os }}-\${{ matrix.node-version }}-

- name: Install Dependencies
run: yarn install --frozen-lockfile
if: |
steps.cache-dependencies.outputs.cache-hit != 'true'
run: yarn install --no-lockfile --non-interactive

- name: Test
run: yarn test:ember --launch \${{ matrix.browser }}
Expand Down Expand Up @@ -2244,16 +2208,12 @@ jobs:
path: |
\${{ steps.global-cache-dir-path.outputs.dir }}
node_modules
key: \${{ runner.os }}-\${{ matrix.node-version }}-\${{
hashFiles('**/package-lock.json'
) }}
key: \${{ runner.os }}-\${{ matrix.node-version }}-floating-deps
restore-keys: |
\${{ runner.os }}-\${{ matrix.node-version }}-

- name: Install Dependencies
run: npm ci
if: |
steps.cache-dependencies.outputs.cache-hit != 'true'
run: npm install --no-package-lock

- name: Test
run: npm run-script test:ember --launch \${{ matrix.browser }}
Expand Down Expand Up @@ -2461,16 +2421,12 @@ jobs:
path: |
\${{ steps.global-cache-dir-path.outputs.dir }}
node_modules
key: \${{ runner.os }}-\${{ matrix.node-version }}-\${{
hashFiles('**/yarn.lock'
) }}
key: \${{ runner.os }}-\${{ matrix.node-version }}-floating-deps
restore-keys: |
\${{ runner.os }}-\${{ matrix.node-version }}-

- name: Install Dependencies
run: yarn install --frozen-lockfile
if: |
steps.cache-dependencies.outputs.cache-hit != 'true'
run: yarn install --no-lockfile --non-interactive

- name: Test
run: yarn test:ember --launch \${{ matrix.browser }}
Expand Down Expand Up @@ -2679,16 +2635,12 @@ jobs:
path: |
\${{ steps.global-cache-dir-path.outputs.dir }}
node_modules
key: \${{ runner.os }}-\${{ matrix.node-version }}-\${{
hashFiles('**/yarn.lock'
) }}
key: \${{ runner.os }}-\${{ matrix.node-version }}-floating-deps
restore-keys: |
\${{ runner.os }}-\${{ matrix.node-version }}-

- name: Install Dependencies
run: yarn install --frozen-lockfile
if: |
steps.cache-dependencies.outputs.cache-hit != 'true'
run: yarn install --no-lockfile --non-interactive

- name: Test
run: yarn test:ember --launch \${{ matrix.browser }}
Expand Down Expand Up @@ -2896,16 +2848,12 @@ jobs:
path: |
\${{ steps.global-cache-dir-path.outputs.dir }}
node_modules
key: \${{ runner.os }}-\${{ matrix.node-version }}-\${{
hashFiles('**/yarn.lock'
) }}
key: \${{ runner.os }}-\${{ matrix.node-version }}-floating-deps
restore-keys: |
\${{ runner.os }}-\${{ matrix.node-version }}-

- name: Install Dependencies
run: yarn install --frozen-lockfile
if: |
steps.cache-dependencies.outputs.cache-hit != 'true'
run: yarn install --no-lockfile --non-interactive

- name: Test
run: yarn test:ember --launch \${{ matrix.browser }}
Expand Down