Update gitlab4j to 6.1.0, update Jenkins BOM, require Jenkins 2.504.3

[zbynek]

Partial fix for JENKINS-76091

Closes #114
Closes #113

Unlike #114 this also updates BOM to latest to resolve some upper bound issues. The latest BOM requires Jenkins 2.504.3 for several components, so the baseline is increased here as well.

Testing done

Tested in runtime with latest release of GitLab branch source and confirmed that it fails to scan branches with an unresolved symbol exception. Tested in runtime with an incremental build of GitLab branch source and confirmed that it scans branches successfully. Expect to see runtime failures in gitlab-oauth plugin when the current release of gitlab-oauth plugin is used with this incremental build.

Ran automated tests of gitlab-oauth plugin and gitlab-logo plugin with this build

• Update gitlab-api dependency gitlab-oauth-plugin#194

Automated tests passing.

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• [n/a] Ensure you have provided tests that demonstrate the feature works or the issue is fixed

[zbynek]

@basil I think this is now ready, except for the incremental repo (which should be reverted with jersey3 release). Installing the incremental builds
https://ci.jenkins.io/job/Plugins/job/gitlab-api-plugin/view/change-requests/job/PR-121/2/artifact/io/jenkins/plugins/gitlab-api/6.1.0-106.v6c0b_5b_df4ee6/gitlab-api-6.1.0-106.v6c0b_5b_df4ee6.hpi
https://ci.jenkins.io/job/Plugins/job/gitlab-oauth-plugin/job/PR-194/3/artifact/org/jenkins-ci/plugins/gitlab-oauth/1.23-rc645.dd84ca_6ea_925/gitlab-oauth-1.23-rc645.dd84ca_6ea_925.hpi
and
https://repo.jenkins-ci.org/incrementals/io/jenkins/plugins/jersey3-api/3.1.11-2.v4a_b_db_cf4557b_/jersey3-api-3.1.11-2.v4a_b_db_cf4557b_.hpi
together with the regular release https://updates.jenkins.io/download/plugins/jakarta-xml-bind-api/4.0.5-3.v3d5b_a_73965b_9/jakarta-xml-bind-api.hpi
makes GitLab Oauth work for me again.

[jmini]

@zbynek as the maintainer of GitLab4J I have been asked in issue gitlab4j/gitlab4j-api#1280 to create a 5.8.1 release that is still on the 5.x.x stream and removes the usage of PropertyNamingStrategy to be compatible with newer Jackson version and still be on Jersey 2.

From my understanding some installations are broken today (see jenkinsci/gitlab-branch-source-plugin#504)

Maybe you can use this 5.8.1 version as a emergency fix until you have found a way forward with Jersey 3.

[jonesbusy]

Thanks! Not a maintainer, so not my decision

In the meanwhile I've open #122

[alecharp]

This still requires a release of jersey3-api plugin and jenkinsci/jackson2-api-plugin#312 to be merged.

[alecharp]

That shouldn't be required as there is

gitlab-api-plugin/.mvn/maven.config

Line 1 in 322a9d1

-Pconsume-incrementals

[alecharp]

@zbynek do you think you can revisit this pull request?

[zbynek]

@alecharp thanks for your feedback, I'll look into those suggestions once jersey3-api is released.

[alecharp]

@alecharp thanks for your feedback, I'll look into those suggestions once jersey3-api is released.

thanks. I asked to adopt the plugin so I could release it. normally, next week is the end of the 2weeks notice so I will release the plugin at the latest by the 20th.

[alecharp]

Some tweak about versions available in BOM but looks good to me. Thanks @zbynek for your work on this.

[MarkEWaite]

Due to the breaking changes in the transition from GitLab API 5.8.x to GitLab API 6.x, we need to plan a coordinated release of this pull request and the dependent pull requests:

• Migrate gitlab api from 5 to 6 gitlab-branch-source-plugin#511
• Update gitlab-api dependency gitlab-oauth-plugin#194
• Use GitLab API plugin 6.1.0 gitlab-logo-plugin#131

If a user installs the new release of GitLab API plugin that includes GitLab API 6.x, without updating any of the other installed plugins, those installed plugins will likely be broken and report errors.

I will be out of the office from Oct 27 - Nov 7, so won't be able to help coordinate the release of those plugins until after I return. Maintainers of those plugins need to all agree that they will release a new version soon after the release of this pull request.

[MarkEWaite]

Changes look good to me. Release needs to be coordinated with the 3 plugins that depend on this plugin.