pom.xml: Use Apache HttpComponents Client 4.x API Plugin #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakub-bochenski
approved these changes
Jul 21, 2019
All recent versions of HttpClient API and Jackson2 API plugins require 2.60.3. It's not a significant requirement change.
This removes httpclient-4.5.2.jar and httpcore-4.4.4.jar from the plugin package, cutting its size by almost a megabyte. Users can update the Apache HttpComponents plugin on their own without waiting for other plugins to update their dependencies. Apache HttpComponents plugin is likely to be installed already because it's used by the git plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's share this dependency like most modern plugins do. No need to bundle our own copy.