Fix UTF8 string length calculation #2508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielBallaSZTE
force-pushed
the
fix_utf8_string_len
branch
from
562cc27 to
1868fe6
Compare
akosthekiss
requested changes
Sep 3, 2018
| for (var i = 0; i < 4000; i++) | ||
| src += "\udc00%f0%90%80%80\udc00"; | ||
| src += "} }"; | ||
| print(src); |
Member
There was a problem hiding this comment.
This file is a duplicate of regression-test-issue-2452.js. It should contain the test case from #2451 instead.
Author
There was a problem hiding this comment.
You are right, thank you!
Fixes jerryscript-project#2451 Fixes jerryscript-project#2452 Fixes jerryscript-project#2453 Co-authored-by: Robert Fancsik <[email protected]> JerryScript-DCO-1.0-Signed-off-by: Daniel Balla [email protected]
DanielBallaSZTE
force-pushed
the
fix_utf8_string_len
branch
from
1868fe6 to
0cf13e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2451
Fixes #2452
Fixes #2453
Co-authored-by: Robert Fancsik [email protected]
JerryScript-DCO-1.0-Signed-off-by: Daniel Balla [email protected]