Skip to content

Fix assertion 'mem_pools == NULL' in the Date constructor. #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2015
Merged

Fix assertion 'mem_pools == NULL' in the Date constructor. #496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions jerry-core/ecma/builtin-objects/ecma-builtin-date.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,10 @@ ecma_date_construct_helper (const ecma_value_t *args, /**< arguments passed to t
{
ret_value = ecma_make_normal_completion_value (ecma_make_number_value (prim_value_p));
}
else
{
ecma_dealloc_number (prim_value_p);
}

return ret_value;
} /* ecma_date_construct_helper */
Expand Down
19 changes: 19 additions & 0 deletions tests/jerry/date-construct.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,22 @@ assert (d.valueOf() == 8.64e+15);

d = new Date(8.64e+15 + 1);
assert (isNaN(d.valueOf()));

var Obj = function (val)
{
this.value = val;
this.valueOf = function () { throw new ReferenceError ("valueOf-" + this.value); };
this.toString = function () { throw new ReferenceError ("toString-"+ this.value); };
};

try
{
d = new Date (new Obj (1), new Obj (2));
// Should not be reached.
assert (false);
}
catch (e)
{
assert (e instanceof ReferenceError);
assert (e.message === "valueOf-1");
}