Swap position of checkout-commit and checkout-branch menu items

[jesseduffield]

We recently added a new option to check out a commit's branch from within the commits, reflog, and sub-commits panels:

After using it for some time, I find it annoying that the default option has changed. I rarely find myself wanting to check out a branch from the commits panel, and it's rarer still to want to check out a branch from the reflog and sub-commits panel. Although there may be use cases for this, it is jarring that something you can always do (checkout the commit) is harder to do than something that you can sometimes do (checkout the branch).

We've also had a user complain about their muscle-memory being broken by the recent change, and I have also fallen victim to this. I don't think that the new branch checkout option is sufficiently useful to dislodge the existing keybinding, so let's swap them.

[stefanhaller]

See #4238.

[YikChingTsui]

Hello, I'm that user that complained, so it's great to see the change. @stefanhaller's suggested workflow to use edit instead of detached head checkout is growing on me. But I discovered a situation where it didn't work well - when repeatedly going back to find a bug. When editing a commit to checkout it, you cannot edit to checkout previous commits, only commits after it.

This is similar to bisect but the first good commit is unknown. My workflow is to checkout (detached head) a past commit, and repeat if bug still exist. When I find a commit where the bug doesn't exist, that commit is the first good commit for git bisect

Do you have any suggestions about this workflow? Thanks for the great project anyhow

[stefanhaller]

In such a situation I usually check out tags, not commits (just did that today, as it happens).

But if I wanted to use the commits view for this, I would probably still use e for doing it. It just requires an additional esc enter (or m a, depending on preference) when I want to go to an earlier one. Since it keeps the scroll position both when going into and out of the rebase, I don't find this too cumbersome.