Skip to content

Investigate whether caching git config is worth it #4240

@jesseduffield

Description

@jesseduffield

From @stefanhaller

The fact that we cache git configs is annoying for testing. I typed git config status.showUntrackedFiles false while lazygit was running, and was confused that it didn't make a difference, until I remembered that we cache git configs. I ran into this before in other cases, and I do wonder if the slight performance gain that we get from caching is worth it compared to this confusion.

We should investigate the performance impact of not caching, and if there's only a marginal difference, we should stop caching git config values, as it's annoying for users who want to change those configs mid-session, and it makes the code more complicated.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions