Skip to content

The exit suffix should also be quoted #4129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

The exit suffix should also be quoted #4129

wants to merge 2 commits into from

Conversation

@rayluo
Copy link

@rayluo rayluo commented Dec 25, 2024

  • PR Description

    • It turns out the exit suffix needs to be quoted as well.
    • I keep the $? but I don't know whether it is necessary.

  • Please check if the PR fulfills these requirements

  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
  • Docs have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

stefanhaller and others added 2 commits December 24, 2024 15:50
@stefanhaller
Fix hang when returning from shell command
bc4cb6f 
In 5a30494 we changed the execution of shell commands to use an interactive
shell (-i), because this allows users to use aliases or shell functions, which
is a nice convenience.

Since then, however, many users have reported problems with lazygit not coming
back to the foreground after executing a shell command. Some users report that
appending "; exit" to the end of the command line solves this. I don't really
understand what the cause of this problem was, or why appending "; exit" solves
it, but if it helps, let's do it.
@rayluo
The exit suffix should also be quoted
f70cad8
@rayluo rayluo mentioned this pull request Dec 25, 2024
Merged
7 tasks
@stefanhaller stefanhaller force-pushed the fix-hang-on-shell-command branch from f9c37d3 to 5fac40c Compare December 28, 2024 13:54
@stefanhaller stefanhaller deleted the branch jesseduffield:fix-hang-on-shell-command December 28, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rayluo @stefanhaller