naming schema adherence #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hema and updated tests in accordance to naming changes
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
AlexAndorra
approved these changes
Jul 12, 2025
There was a problem hiding this comment.
Thanks @Dekermanjian , looks good! Just two things:
test_find_MAP_basinhoppingis failing, but that looks unrelated. Maybe you need to pull origin to get the fix? (cc @jessegrabowski )- You may want to remove the notebook, since I understand we're dropping it
|
The failures will go away after we merge. I'll handle the notebook on the main PR |
jessegrabowski
merged commit 08085c7
into
jessegrabowski:multivariate-structural
10 of 13 checks passed
Sorry about that I completely forgot to delete the notebook! Okay, and it looks like the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated leveltrend, seasonal, cycle components to adhere to naming schema and updated tests in accordance to naming changes