Passing a notify flag complains that jest doesn't exit after the test run has completed

[natealcedo]

💥 Regression Report

I'm not sure which last version this feature was working in but I've recreated a simple repo just to show that this feature isn't working as intended.

Last working version

I don't know which version this feature was working correctly.

Stopped working in version:

Currently running on jest 24.1

To Reproduce

Steps to reproduce the behavior:

Run any test suite with --notify flag

Here's a screenshot

Expected behavior

The test suite should exit cleanly.

Link to repl or repo (highly encouraged)

https://github.com/natealcedo/notify/

Run npx envinfo --preset jest

Paste the results here:

  System:
    OS: macOS 10.14.3
    CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
  Binaries:
    Node: 8.15.0 - ~/.nvm/versions/node/v8.15.0/bin/node
    Yarn: 1.13.0 - ~/.nvm/versions/node/v8.15.0/bin/yarn
    npm: 6.4.1 - ~/.nvm/versions/node/v8.15.0/bin/npm
  npmPackages:
    jest: ^24.1.0 => 24.1.0

[SimenB]

Interesting! Seems like we don't clean up the notifier. I've tried to play around with timeout and wait with no luck. Not sure how to solve this. The notification behaves correctly even if I kill the node process running Jest. So I wonder if we just need a way for node-notifier to really fire and forget - now it seems it waits no matter what for terminal-notifier (on mac) to exit.

All the execs in here will cause the process to wait until they complete: https://github.com/mikaelbr/node-notifier/blob/2275295e570e9edf33105d4f62e9eb3e7dbb1b69/lib/utils.js#L54-L61

Maybe open up an issue there?

[trickpeeraze]

Found this issue as well :(

[abhishek-1985]

I think this issue is related to the node-notifier 5.4 version issue :- mikaelbr/node-notifier#271

According to node-notifier - As of 5.4.0, `timeout` defaults to `10`. In order to have a "fire and forgotten" notification, you need to set `timeout` to `false`.

[SimenB]

Thanks for the link @abhishek-1985! Seems like they plan a revert and a major bump. This seems reasonable to me as updating old Jest's are difficult. Happy to bump our dependency here after they publish a major and set timeout: false like that PR adds

[SimenB]

Change reverted in node-notifier. Will have to figure something about when upgrading to v6

[shirshak55]

This issue really sucks today i got this issue and wasted whole lot of time . And I kept debugging if it was redis/ typeorm connection pool bla bla bla :(

[SimenB]

Woops, reintroduced this when upgrading to v6. I'll fix it