fix(jest-mock): add index signature support for spyOn types
#13013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you! |
This was referenced Aug 3, 2022
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13012
Adapted from https://github.com/DefinitelyTyped/DefinitelyTyped/pull/60971/files
Summary
As it is explained in the linked issue (and also #12966), currently
spyOntypes do not handle index signatures. Thanks to @Maxim-Mazurok, a fix landed in@types/jest. Here I adapted it for Jest types to make it work throughimport {jest} from '@jest/globals'.@Maxim-Mazurok could you take a look, please? (;
Test plan
Type tests are added. They are failing on
main, but should pass on this branch.