Skip to content

Allow testMatch to take a string value #15734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 13, 2025

Conversation

spenserblack
Copy link
Contributor

Summary

Inspired by a mistake I made while modifying the config. I was surprised that testMatch only took an array of strings, and not a string value. This struck me as a bit unusual, especially since a similar option, testRegex, takes string | string[].

Test plan

Wrote a test case for the normalize function to assert that "some string" gets transformed to ["some string"].

Copy link

linux-foundation-easycla bot commented Jul 11, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

netlify bot commented Jul 11, 2025

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 13d5d3b
🔍 Latest deploy log https://app.netlify.com/projects/jestjs/deploys/6870798c62b2b9000868f1c4
😎 Deploy Preview https://deploy-preview-15734--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

pkg-pr-new bot commented Jul 11, 2025

Open in StackBlitz

babel-jest

npm i https://pkg.pr.new/babel-jest@15734

babel-plugin-jest-hoist

npm i https://pkg.pr.new/babel-plugin-jest-hoist@15734

babel-preset-jest

npm i https://pkg.pr.new/babel-preset-jest@15734

create-jest

npm i https://pkg.pr.new/create-jest@15734

@jest/diff-sequences

npm i https://pkg.pr.new/@jest/diff-sequences@15734

expect

npm i https://pkg.pr.new/expect@15734

@jest/expect-utils

npm i https://pkg.pr.new/@jest/expect-utils@15734

jest

npm i https://pkg.pr.new/jest@15734

jest-changed-files

npm i https://pkg.pr.new/jest-changed-files@15734

jest-circus

npm i https://pkg.pr.new/jest-circus@15734

jest-cli

npm i https://pkg.pr.new/jest-cli@15734

jest-config

npm i https://pkg.pr.new/jest-config@15734

@jest/console

npm i https://pkg.pr.new/@jest/console@15734

@jest/core

npm i https://pkg.pr.new/@jest/core@15734

@jest/create-cache-key-function

npm i https://pkg.pr.new/@jest/create-cache-key-function@15734

jest-diff

npm i https://pkg.pr.new/jest-diff@15734

jest-docblock

npm i https://pkg.pr.new/jest-docblock@15734

jest-each

npm i https://pkg.pr.new/jest-each@15734

@jest/environment

npm i https://pkg.pr.new/@jest/environment@15734

jest-environment-jsdom

npm i https://pkg.pr.new/jest-environment-jsdom@15734

@jest/environment-jsdom-abstract

npm i https://pkg.pr.new/@jest/environment-jsdom-abstract@15734

jest-environment-node

npm i https://pkg.pr.new/jest-environment-node@15734

@jest/expect

npm i https://pkg.pr.new/@jest/expect@15734

@jest/fake-timers

npm i https://pkg.pr.new/@jest/fake-timers@15734

@jest/get-type

npm i https://pkg.pr.new/@jest/get-type@15734

@jest/globals

npm i https://pkg.pr.new/@jest/globals@15734

jest-haste-map

npm i https://pkg.pr.new/jest-haste-map@15734

jest-jasmine2

npm i https://pkg.pr.new/jest-jasmine2@15734

jest-leak-detector

npm i https://pkg.pr.new/jest-leak-detector@15734

jest-matcher-utils

npm i https://pkg.pr.new/jest-matcher-utils@15734

jest-message-util

npm i https://pkg.pr.new/jest-message-util@15734

jest-mock

npm i https://pkg.pr.new/jest-mock@15734

@jest/pattern

npm i https://pkg.pr.new/@jest/pattern@15734

jest-phabricator

npm i https://pkg.pr.new/jest-phabricator@15734

jest-regex-util

npm i https://pkg.pr.new/jest-regex-util@15734

@jest/reporters

npm i https://pkg.pr.new/@jest/reporters@15734

jest-resolve

npm i https://pkg.pr.new/jest-resolve@15734

jest-resolve-dependencies

npm i https://pkg.pr.new/jest-resolve-dependencies@15734

jest-runner

npm i https://pkg.pr.new/jest-runner@15734

jest-runtime

npm i https://pkg.pr.new/jest-runtime@15734

@jest/schemas

npm i https://pkg.pr.new/@jest/schemas@15734

jest-snapshot

npm i https://pkg.pr.new/jest-snapshot@15734

@jest/snapshot-utils

npm i https://pkg.pr.new/@jest/snapshot-utils@15734

@jest/source-map

npm i https://pkg.pr.new/@jest/source-map@15734

@jest/test-result

npm i https://pkg.pr.new/@jest/test-result@15734

@jest/test-sequencer

npm i https://pkg.pr.new/@jest/test-sequencer@15734

@jest/transform

npm i https://pkg.pr.new/@jest/transform@15734

@jest/types

npm i https://pkg.pr.new/@jest/types@15734

jest-util

npm i https://pkg.pr.new/jest-util@15734

jest-validate

npm i https://pkg.pr.new/jest-validate@15734

jest-watcher

npm i https://pkg.pr.new/jest-watcher@15734

jest-worker

npm i https://pkg.pr.new/jest-worker@15734

pretty-format

npm i https://pkg.pr.new/pretty-format@15734

commit: 13d5d3b

Copy link
Member

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good fix, thank you!

@cpojer cpojer merged commit 4d57381 into jestjs:main Jul 13, 2025
76 checks passed
@spenserblack spenserblack deleted the feature/string-test-match branch July 14, 2025 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants