Removed redundant check for NaN in parseShardPair #15742
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The final
.filter(shard => !Number.isNaN(shard))
was redundant and safely removed.Here’s why:
The previous
.filter(d => /^\d+$/.test(d))
already ensures that only strings containing digits only (e.g., "123") are passed to.map(...)
.parseInt("123", 10)
will always return a valid number (123), not NaN, when the input is purely numeric.Therefore, checking
!Number.isNaN(shard)
after parsing is unnecessary — it's dead code that doesn't affect the result.The cleanup removes an unnecessary
filter()
step that was guarding against a case that cannot occur due to the previous regex check. It simplifies the code while keeping the same functionality.Test plan