Skip to content

Fix snapshots #6113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2018
Merged

Fix snapshots #6113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions integration-tests/__tests__/__snapshots__/globals.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ exports[`cannot test with no implementation 1`] = `
| ^
4 | test('test, no implementation');
5 |

at packages/jest-jasmine2/build/jasmine/Env.js:<<LINE>>:<<COLUMN>>
at __tests__/only-constructs.test.js:<<LINE>>:<<COLUMN>>

Expand Down Expand Up @@ -60,7 +60,7 @@ exports[`cannot test with no implementation with expand arg 1`] = `
| ^
4 | test('test, no implementation');
5 |

at packages/jest-jasmine2/build/jasmine/Env.js:<<LINE>>:<<COLUMN>>
at __tests__/only-constructs.test.js:<<LINE>>:<<COLUMN>>

Expand Down
14 changes: 10 additions & 4 deletions integration-tests/__tests__/globals.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,12 @@ beforeEach(() => {

afterAll(() => cleanup(DIR));

// This function is needed due to differences between Node 6 and 8-9-10 when
// returning the result of the error.
function clean(text) {
return text.replace(/([\r\n])\s+(?=[\r\n])/g, '$1').replace(/\s+\^/g, ' ^');
}

test('basic test constructs', () => {
const filename = 'basic.test-constructs.test.js';
const content = `
Expand Down Expand Up @@ -123,8 +129,8 @@ test('cannot test with no implementation', () => {
expect(status).toBe(1);

const {summary, rest} = extractSummary(stderr, {stripLocation: true});
expect(rest).toMatchSnapshot();
expect(summary).toMatchSnapshot();
expect(clean(rest)).toMatchSnapshot();
expect(clean(summary)).toMatchSnapshot();
});

test('skips with expand arg', () => {
Expand Down Expand Up @@ -201,8 +207,8 @@ test('cannot test with no implementation with expand arg', () => {
expect(status).toBe(1);

const {summary, rest} = extractSummary(stderr, {stripLocation: true});
expect(rest).toMatchSnapshot();
expect(summary).toMatchSnapshot();
expect(clean(rest)).toMatchSnapshot();
expect(clean(summary)).toMatchSnapshot();
});

test('function as descriptor', () => {
Expand Down