chore: Check copyright and license as one joined substring #8815
Conversation
scripts/checkCopyrightHeaders.js
Outdated
| function needsCopyrightHeader(file) { | ||
| const contents = getFileContents(file); | ||
|
|
||
| // Match lines individually to avoid false positive for: |
There was a problem hiding this comment.
@pedrottimark Yes the line endings now shouldn't be a problem as they're required to be LF. But this comment says another reason why lines are checked individually is the ability to use line comments instead of a block comment. Looks like this possibility is never used (CI is green) but wondering if these line substrings are the standard license header check for FB or something.
There was a problem hiding this comment.
Sorry to make you do the proof reading that I should have done, because I wrote that comment in the previous PR and that sentence was a step in the wrong direction.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
4 participants
Summary
What do y’all think? In the first draft of #8783 a joined substring found some mistakes:
All rights reserved.line between copyright and licensecheckCopyrightHeaders.jsitself ;)that searching for the 3 lines independently (in the merged code) does not find
Test plan
yarn check-copyright-headersAfter #8809 the script will pass when run locally on Windows system, correct?
Tim, thanks again for researching such a smart solution ❤️