Fix vectored I/O #26
Merged
Fix vectored I/O #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `ioVec` does not depend on `feature="collections"` - Fix `impl Read for Take`; only `read_to_end` requires `feature="collections"` - Fix some whitespace consistency issues Closes jethrogb#19
Contributor
Author
|
Pinging @jethrogb I know this is an ugly PR to review. Sorry about that. |
Owner
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 13, 2019
26: Fix vectored I/O r=jethrogb a=parasyte This is a large PR because I recreated all patches from #18. Contains the following fixes: - `ioVec` does not depend on `feature="collections"` - Fix `impl Read for Take`; only `read_to_end` requires `feature="collections"` - Fix some whitespace consistency issues Closes #19 Co-authored-by: Jay Oster <[email protected]>
Contributor
Build succeeded
|
Owner
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a large PR because I recreated all patches from #18. Contains the following fixes:
ioVecdoes not depend onfeature="collections"impl Read for Take; onlyread_to_endrequiresfeature="collections"Closes #19