Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

Conversation

JoshVanL
Copy link
Contributor

Signed-off-by: JoshVanL [email protected]

/assign @munnerz

@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Mar 26, 2020
@jetstack-bot jetstack-bot requested a review from simonswine March 26, 2020 15:27
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 26, 2020
@@ -1,5 +1,5 @@
apiVersion: v1
appVersion: "v0.2.0"
appVersion: "v0.3.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the ‘version’ field in this file? Should that be bumped too?

@JoshVanL
Copy link
Contributor Author

Updated the PR @munnerz

@jetstack-bot jetstack-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 30, 2020
@munnerz
Copy link

munnerz commented Mar 30, 2020 via email

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2020
@jetstack-bot jetstack-bot merged commit 8160ef5 into jetstack:master Mar 30, 2020
@jetstack-bot jetstack-bot added this to the v0.2 milestone Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants