Set finalizer on underlying Memory object in Julia 1.11+
#11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Julia 1.11+ with the new `Memory` object, the memory is not actually owned by the constructed `Array` and therefore the finalizer may trigger too early when the underlying memory is transfered from an `Array` to a different kind of owner (such as `IOBuffer`). Fix this by conditionally checking for the Julia 1.11+ behavior, and instead setting the finalizer on the `Memory`, if necessary. Duplicates the improvement made to the Mmap stdlib's implementation: JuliaLang/julia#54210
jmert
force-pushed
the
jw/jl_memory_finalizer
branch
from
77ad496 to
a95270e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Julia 1.11+ with the new
Memoryobject, the memory is not actually owned by the constructedArrayand therefore the finalizer may trigger too early when the underlying memory is transfered from anArrayto a different kind of owner (such asIOBuffer).Fix this by conditionally checking for the Julia 1.11+ behavior, and instead setting the finalizer on the
Memory, if necessary.Duplicates the improvement made to the Mmap stdlib's implementation: JuliaLang/julia#54210